Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor readability improvement #23157

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 11, 2022

Overview

Minor readability improvement

Before

response_code is a bit opaque

After

$this->isSuccess()

Technical Details

This just adds isSuccess as a function to avoid having to understand what
response code is.

I grepped & didn't find 'response_code' outside the class/test

I also confirmed that the retrieve function casts to an int (via
validate) so the triple = is correct

Comments

This facilitates some more cleanup

This just adds isSuccess as a function to avoid having to understand what
response code is.

I grepped & didn't find 'response_code' outside the class/test

I also confirmed that the retrieve function casts to an int (via
validate) so the triple = is correct
@civibot
Copy link

civibot bot commented Apr 11, 2022

(Standard links)

@civibot civibot bot added the master label Apr 11, 2022
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb is this something you could merge - pretty simple tidy up

@monishdeb
Copy link
Member

Yep, a simple change to improve readability.

@monishdeb monishdeb merged commit 4917687 into civicrm:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants