Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor readability improvement
Before
response_code
is a bit opaqueAfter
$this->isSuccess()
Technical Details
This just adds isSuccess as a function to avoid having to understand what
response code is.
I grepped & didn't find 'response_code' outside the class/test
I also confirmed that the retrieve function casts to an int (via
validate) so the triple = is correct
Comments
This facilitates some more cleanup