Fix backward-compatability for new method in CRM_Contact_BAO_Query_Hook #22933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Should this be against 5.48? |
|
Yes, whoops that's what I meant. And then we can backport it to 5.47. |
The method getDefaultReturnProperties was just added to CRM_Contact_BAO_Query_Hook, but some extensions do not yet implement it, and also do not extend that class so cannot inherit the default method. This adds a guard around calling the new method to avoid crashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The method
getDefaultReturnPropertieswas just added toCRM_Contact_BAO_Query_Hook, but some extensions do not yet implement it, and also do not extend that class so cannot inherit the default method.This adds a guard around calling the new method to avoid crashes.
See discussion in #22064 (comment)