Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3100 - Remove grant leftovers from core xml. Remove empty grant reports menu #22911

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 9, 2022

This ports #22893 from @demeritcowboy to 5.48

@civibot
Copy link

civibot bot commented Mar 9, 2022

(Standard links)

@civibot civibot bot added the 5.48 label Mar 9, 2022
@demeritcowboy
Copy link
Contributor

Is this waiting on something still? It runs ok for me.

Not a blocker but if the reasoning for moving it is to catch people in the last 2 days who've already installed 5.48 beta1, then my understanding is it should go in a function called beta2. But historically civi doesn't follow that pattern much, and it's only 2 days, and there's an understanding that they live on the edge if they install such things.

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Mar 9, 2022
@colemanw
Copy link
Member Author

colemanw commented Mar 9, 2022

Let's merge it before 2 days becomes 3!

@colemanw colemanw merged commit 3af32cd into civicrm:5.48 Mar 9, 2022
@colemanw colemanw deleted the grant-reports2 branch March 9, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.48 merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants