Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.47 #22888

Merged
merged 7 commits into from
Mar 4, 2022
Merged

5.47 #22888

merged 7 commits into from
Mar 4, 2022

Conversation

seamuslee001
Copy link
Contributor

No description provided.

totten and others added 7 commits March 2, 2022 21:34
This guard was added by 912511a as part of
a previous approach to managing hooks during upgrades.  This general
approach changed with #17126; so
17126 partially undid this... but it inadvertently had the effect of
completely disabling `reconcile()` (because this guard was left).
Before
------

`migrateCiviGrant()` migrates some metadata from core-ownership to
core-extension-ownership...  and it ALSO activates the extension.  However,
the extension depends on other (possibly-inactive) extensions.  This
creates an inconsistent state (where active parts of `civigrant`
depend on inactive parts of `search_kit`).

In this inconsistent state, `ManagedEntities::reconcile()` fails.

After
-----

`migrateCiviGrant()` still migrates metadata.  However, it initially leaves
the extension inactive.  So `ManagedEntities::reconcile()` won't try to
setup these records.

After core schema is fully resolved, then it installs all necessary
extensions using normal mechanisms (with normal ordering).
Note: This step was added to the codebase circa 5.47. The underlying schema
change actually originated circa 5.46. The step should be idempotent.
@civibot
Copy link

civibot bot commented Mar 4, 2022

(Standard links)

@civibot civibot bot added the master label Mar 4, 2022
@seamuslee001 seamuslee001 merged commit 3675754 into master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants