Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh entity list after updating custom group (self_hook_*) #22868

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

totten
Copy link
Member

@totten totten commented Mar 2, 2022

Overview

The CustomGroups are used to generate virtual entities (if they set is_multiple). Toggling is_multiple
should cause the virtual entity to be added or removed.

This is an alternative variant of #22843.

Reproduction steps

  1. Create a custom data group. Leave default is_multiple=0.
  2. View "API Explorer". Look for the virtual entity. (It's not there. Properly so.)
  3. Edit custom data group. Change to is_multiple=1.
  4. Reload "API Explorer". Look for the virtual entity.

Before

The entity does not appear. You have to do a system-flush.

After

The entity does appear.

Overview
----------------------------------------

The CustomGroups are used to generate virtual entities (if they set `is_multiple`). Toggling `is_multiple`
should cause the virtual entity to be added or removed.

Reproduction steps
----------------------------------------

1. Create a custom data group. Leave default `is_multiple=0`.
2. View "API Explorer". Look for the virtual entity. (It's not there. Properly so.)
3. Edit custom data group. Change to `is_multiple=1`.
4. Reload "API Explorer". Look for the virtual entity.

Before
----------------------------------------

The entity does not appear. You have to do a system-flush.

After
----------------------------------------

The entity does appear.
@civibot
Copy link

civibot bot commented Mar 2, 2022

(Standard links)

@totten
Copy link
Member Author

totten commented Mar 6, 2022

Merging based on @colemanw sign-off in the discussion of #22843. (The two are basically the same - and the discussion about trade-offs is in the other.)

This has test-coverage and addresses an alpha regression, so it's easier to merge before freezing for beta.

@totten totten merged commit c4f3667 into civicrm:master Mar 6, 2022
@totten totten deleted the master-flush2 branch March 6, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant