(NFC) LoggingDetailTest - Improve reliability of test #22867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ----------------- If you run this test repeatedly, it may alternately pass and fail. The percentage of passes-vs-fails can vary widely (depending on the computer where you execute). To test this, I went to a deployment (on `test-3`) which had a fairly high probability of failure (*failure in roughly 3/4 invocations*). After ----------------- On the same system, it passes consistently (*no failures after 15 invocations*).
|
(Standard links)
|
|
Cool beans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improve test reliability.
This was discussed/investigated on Mattermost among @demeritcowboy, @seamuslee001, and me. Investigation starts around https://chat.civicrm.org/civicrm/pl/ti75i31u9frq9kfgxef5qfko3y
Before
If you run this test repeatedly, it may alternately pass and fail. The percentage of passes-vs-fails can vary widely (depending on the computer where you execute).
For example, on
test-3, I observed a fairly high probability of test-failure (failure in roughly 3/4 invocations).After
On the same system, it passes consistently (no failures after 15 invocations).