Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark methods which are only used statically as static #22844

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Feb 27, 2022

Overview

The methods updated in this PR are only ever called statically; this correclty marks the methods as static to avoid PHP and IDE warnings.

Before

Non-static methods called statically.

After

Better code quality.

@civibot
Copy link

civibot bot commented Feb 27, 2022

(Standard links)

@civibot civibot bot added the master label Feb 27, 2022
@colemanw colemanw merged commit bb62803 into civicrm:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants