Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cody tidy in CRM_Core_State #22841

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Conversation

braders
Copy link
Contributor

@braders braders commented Feb 26, 2022

Overview

This tidies CRM_Core_State in 3 ways:

  • Documents the $page params as CRM_Core_Form rather than CRM_Core_Page. This is required as CRM_Core_Page does not extend HTML_QuickForm_Page and so does not have the necessary handle method.
  • Removes the getNextState class. This has not been used in CiviCRM core for at least 9 years, and cannot work correctly as $page is undefined.
  • Removes the debugPrint method. This is not used in CiviCRM core and would be unlikely to work correctly as CRM_Core_State would not be castable to a string (i.e. _next and _back).

Before

Various code quality issues.

After

Fewer code quality issues in CRM_Core_State.

@civibot
Copy link

civibot bot commented Feb 26, 2022

(Standard links)

@civibot civibot bot added the master label Feb 26, 2022
@demeritcowboy demeritcowboy merged commit c167fbf into civicrm:master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants