Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Rename RecurForms test class #22820

Merged
merged 2 commits into from
Feb 23, 2022
Merged

[NFC] Rename RecurForms test class #22820

merged 2 commits into from
Feb 23, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

I was confused by the naming of this class. It didn't indicate whether it was a test itself, base class, or helper. Also the docblock had a different name.

Before

RecurForms

After

RecurFormsTrait

Technical Details

Comments

Is test

@civibot
Copy link

civibot bot commented Feb 23, 2022

(Standard links)

@civibot civibot bot added the master label Feb 23, 2022
@demeritcowboy demeritcowboy changed the title [NFC] Rename RecurForms class [NFC] Rename RecurForms test class Feb 23, 2022
@colemanw colemanw merged commit dd1bb7a into civicrm:master Feb 23, 2022
@demeritcowboy demeritcowboy deleted the recurforms branch February 23, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demeritcowboy @colemanw