Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove old require_once statements made obsolete by autoloader #22792

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

colemanw
Copy link
Member

Overview

Removes unnecessary code leftover from PHP 4.

Technical Details

All of these require_once are requiring classes beginning with CRM_, which is definitely handled by our autoloader.

@civibot
Copy link

civibot bot commented Feb 18, 2022

(Standard links)

@civibot civibot bot added the master label Feb 18, 2022
@totten
Copy link
Member

totten commented Feb 19, 2022

Agree these statements look like they should work with the autoloader.

Most of these changes probably get some kind of coverage via unit-tests, although unit-tests are slightly unrepresentative (because classloading is generally done once-per-suite rather than once-per-use-case). So I did some light r-run that touched a few of these (eg use some admin screens with getIdAndAction; eg use an exporter). Worked well.

Merging.

@totten totten merged commit 6358a75 into civicrm:master Feb 19, 2022
@colemanw colemanw deleted the autoloader branch February 19, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants