RecurForms test fixes #22784
Merged
RecurForms test fixes #22784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
commented
Feb 17, 2022
| 'is_send_contribution_notification' => FALSE, | ||
| ], | ||
| ]); | ||
| $this->callAPISuccess('Payment', 'create', [ |
There was a problem hiding this comment.
This doesn't have to be separated. I just find it a bit easier to debug this way.
mattwire
commented
Feb 17, 2022
| @@ -58,6 +64,7 @@ public function getContributionRecurID(): int { | |||
| 'installments' => 12, | |||
| 'frequency_interval' => 1, | |||
| 'frequency_unit' => 'month', | |||
| 'payment_processor_id' => $this->paymentProcessorId, | |||
There was a problem hiding this comment.
This is the important change
This was referenced Feb 17, 2022
|
Cool. Interesting the name of the test class doesn't end in "Test" - has this been running? I don't see it in the list on another PR run I picked at random. |
|
@demeritcowboy It's a helper for CRM_Contribute_Form_CancelSubscriptionTest and UpdateSubscriptionTest. I didn't name the classes :-) |
|
Ahhh. Ok. I'll probably put up a PR after to add a comment and remove the |
|
Oh I see it's actually a base class. So then I'll probably rename it to Base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Found via #21895
Before
Tests not setting payment_processor_id on contribution recur so defaults to "manual".
After
Tests setting payment_processor_id on contribution recur so uses the one we actually chose.
Technical Details
Comments
@demeritcowboy