Fix submit handling of thousands when creating data entry batch #22772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
batch
branch
from
c51adc7
to
d2e1d0a
Compare
eileenmcnaughton
force-pushed
the
batch
branch
from
d2e1d0a
to
448259d
Compare
|
test this please |
1 similar comment
|
test this please |
|
@colemanw @demeritcowboy can anyone check this - it was failing tests before for reasons not related to this PR |
|
I think this is ok. It creates a bunch of new E_NOTICES that weren't there before but I guess that's what you're referring to in the description. Noting that this creation page seems to work with euro settings too, but then the actual batch page doesn't really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix submit handling of thousands when creating data entry batch
Before
When creating a new batch entering the total batch amount with a comma (eg. 5,000.00) results in the amount being truncated
After
Saves correctly
Technical Details
Note I tested & the apiv4 does fine at handling created_id & created_date so I removed that from the form
Comments
I noticed some other issues around this flow - I think I have another PR open for the enotices so I kept this PR tightly constrained to post process