Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix issue where spaces in payment_processor_type.name field cau… #22760

Conversation

seamuslee001
Copy link
Contributor

…ses issues with class output on form

Overview

This fixes an issue raised by @KarinG in mattermost that if you install the iats extension then you will find that rather than having one class you get about 5 css classes outputed.

Before

Multiple classes added when using a payment processor of type that has a space in the name

After

1 class outputted

ping @demeritcowboy @eileenmcnaughton @adixon

@civibot
Copy link

civibot bot commented Feb 11, 2022

(Standard links)

@civibot civibot bot added the master label Feb 11, 2022
@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@demeritcowboy demeritcowboy merged commit 322b5ee into civicrm:master Feb 11, 2022
@adixon
Copy link
Contributor

adixon commented Feb 11, 2022

Whoa, amazing what happens when I'm sleeping.

I would have munged it with an "-" instead of a "_" and that 1000 max length sounds like a terrible idea (why not the default 63?).

But for sure, this fixes it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants