dev/core#3063 APIv3 - Fix numeric option matching #22751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: Option matching was skipped for all FK fields if a numeric value was given After: Only skipped for `campaign_id` and `payment_processor_id` fields The optimization was overly broad and had unintended side-effects
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the important bit of #22740 with a workaround to avoid the pitfalls that made it a boondoggle.
Fixes dev/core#3063.
Before: Option matching was skipped for all FK fields if a numeric value was given
After: Only skipped for
campaign_idandpayment_processor_idfieldsAdded
payment_processor_idto the exception for the sake of this backport to make it pass tests.