Some more notice fixes in smarty

[eileenmcnaughton]

No description provided.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I'm not seeing these notices. Did they already get fixed somewhere else?

[eileenmcnaughton]

@demeritcowboy they would probably only show up with smarty grumpy mode (+ debug)

if (!defined('CIVICRM_SMARTY_DEFAULT_ESCAPE')) {
  define('CIVICRM_SMARTY_DEFAULT_ESCAPE', TRUE);
}

[demeritcowboy]

I had tried that but I forgot you need to clear cache if you still have the "regular" compiled template in templates_c.

Looks good. Why does it seem like every time one of these warnings is squashed 8 more take its place...

[eileenmcnaughton]

@demeritcowboy yeah good question :-)