Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/user-interface#45 Show associated participants on contributionView form #22732

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Feb 8, 2022

Overview

Fixes dev/user-interface#45. Show associated participants on contributionView form.

As outlined on GitLab this introduces a way to navigate to participants from the contribution view:

Screenshot_2022-02-04_at_08 53 53

This is done by reading the associated participants from the contribution line items using API4. If this is successfully reviewed I'll consider implementing similar functionality to list the purchased membership(s) on the view contribution screen. This should make the contribution view much more useful for CiviCRM users.

@civibot
Copy link

civibot bot commented Feb 8, 2022

(Standard links)

@civibot civibot bot added the master label Feb 8, 2022
@braders braders force-pushed the ui-45-contrib-participant-links branch from cf7fda2 to 4a9939e Compare February 8, 2022 21:41
@braders braders force-pushed the ui-45-contrib-participant-links branch from 4a9939e to 1daa1b5 Compare February 8, 2022 22:15
@jaapjansma
Copy link
Contributor

test this please

@jaapjansma
Copy link
Contributor

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would noticeably impact the user-experience (eg requiring retraining), but this has been addressed with a suitable transition/communication plan.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: We created an event with multiple participant registration and then we signed up on the live page and afterwards checked the created contribution.
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change is trivial enough that it does not require tests.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@eileenmcnaughton or @colemanw can one of you merge this PR? @bettydofling and I have reviewed this PR and we think this can be merged.

@jaapjansma jaapjansma added the merge ready PR will be merged after a few days if there are no objections label Feb 28, 2022
@mattwire mattwire merged commit 6650f83 into civicrm:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants