Test setting/getting a multivalue customfield with date+time #22726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
force-pushed
the
customvaluefailingtest
branch
2 times, most recently
from
12d9709
to
9b2f81b
Compare
mattwire
force-pushed
the
customvaluefailingtest
branch
from
9b2f81b
to
30d44dc
Compare
colemanw
reviewed
Feb 8, 2022
Comment on lines
+94
to
+96
| ->addValue('data_type:name', 'Date') | ||
| ->addValue('html_type:name', 'Select Date') | ||
| ->addValue('date_format:name', 'yy-mm-dd (2009-12-31)') |
There was a problem hiding this comment.
This is a separate issue, but I looked at this code and suddenly realized that APIv4 thinks translatable labels are the same thing as machine names. Yikes! That's definitely wrong and these 3 lines should not work. I've put up #22730 which will fix the bug (and break this api call, it should be updated to not use the :name suffix anyway).
|
#22731 fixes the issue and hopefully doesn't cause any other test failures. |
|
Thanks @colemanw |
|
Amazingly, all tests passed! If you could leave a review on that PR @mattwire we can get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@colemanw We should be able to set a multivalue customfield date field with date+time but it doesn't seem to work? See test.
Before
After
Technical Details
Comments