REF - Use function to get component name from permission

[colemanw]

Overview

Refactors some long-winded code which was attempting to do what an existing function does better

Before

Try to guess component name from permission name, based on string fudgery

After

Use a function which does it without guessing

Comments

I'm fairly certain this change is correct, but someone else should look at it to ensure I'm not missing some important difference between the existing code (silly as it was) and the new function.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Retest this please

[demeritcowboy]

I can take a look.

[demeritcowboy]

Looks ok.

One sanity check I did was to compare the before/after output of cv ev --user=something "$perms = CRM_Core_Permission::basicPermissions(); foreach ($perms as $p => $dontcare) { var_dump(CRM_Core_BAO_Dashboard::checkPermission([$p], null)); }" with admin/regular/anonymous users. Checks out.

This function also appears to only be called from one place in universe (the same file), so it limits the scope. I'm ok to merge just might be worth making the function private.

[colemanw]

Wow, a triple negative! I wonder if there's a simpler way to write that?

[demeritcowboy]

Hehe. Seems there isn't not a way to avoid it.

[colemanw]

I wouldn't be unsurprised if we couldn't simplify it.

[colemanw]

Ok @demeritcowboy I changed the function to be private and added some additional cleanup for your reviewing pleasure :)