-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer install the Contribution Cancel Actions, CiviCRM Core Extension by default on new CiviCRM sites #22686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Cancel Actions on new CiviCRM sites.
(Standard links)
|
I would propose that those tests get moved to the extension rather than deleted all together, that way we can be sure that if someone did enable the extension then the code still works as it previously did right? |
this moves two #24340 |
test this please - in theory it should pass now |
civibot, test this please |
Still the same - maybe affected all master at the moment? test this please |
seamuslee001
added a commit
that referenced
this pull request
Sep 21, 2022
Regenerate civicrm_generated after #22686 and codegen params to in_array are backwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
No longer install the Contribution Cancel Actions, CiviCRM Core Extension by default on new CiviCRM sites.
See https://lab.civicrm.org/dev/core/-/issues/2517
Before
Contribution Cancel Actions, extension installed by default on new CiviCRM sites.
After
Contribution Cancel Actions, extension NOT installed by default on new CiviCRM sites.
Technical Details
Comments
Because @eileenmcnaughton said:
Rebased copy of #21673
Agileware Ref: CIVICRM-1851