Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer install the Contribution Cancel Actions, CiviCRM Core Extension by default on new CiviCRM sites #22686

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

agileware-justin
Copy link
Contributor

Overview

No longer install the Contribution Cancel Actions, CiviCRM Core Extension by default on new CiviCRM sites.
See https://lab.civicrm.org/dev/core/-/issues/2517

Before

Contribution Cancel Actions, extension installed by default on new CiviCRM sites.

After

Contribution Cancel Actions, extension NOT installed by default on new CiviCRM sites.

Technical Details

Comments

Because @eileenmcnaughton said:

I think the next step in deprecating the extension is to remove it from the sql that installs in on new CiviCRM installs. I would merge a PR that did that if I saw one

Rebased copy of #21673

Agileware Ref: CIVICRM-1851

@civibot
Copy link

civibot bot commented Feb 2, 2022

(Standard links)

@seamuslee001
Copy link
Contributor

I would propose that those tests get moved to the extension rather than deleted all together, that way we can be sure that if someone did enable the extension then the code still works as it previously did right?

@eileenmcnaughton
Copy link
Contributor

this moves two #24340

@eileenmcnaughton
Copy link
Contributor

test this please - in theory it should pass now

@totten
Copy link
Member

totten commented Sep 19, 2022

civibot, test this please

@eileenmcnaughton
Copy link
Contributor

Still the same - maybe affected all master at the moment? test this please

@demeritcowboy demeritcowboy merged commit 528cbc9 into civicrm:master Sep 20, 2022
seamuslee001 added a commit that referenced this pull request Sep 21, 2022
Regenerate civicrm_generated after #22686 and codegen params to in_array are backwards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants