Afform - Rename blocks and joins for clarity #21218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Test fails look related but other than that this looks fine to me @colemanw |
colemanw
force-pushed
the
afformLocationType
branch
from
08b91ff
to
461bcb7
Compare
Renames the ambiguously named "block" and "join" afform properties,
and changes the naming convention to "af{type}-title-munged".
colemanw
force-pushed
the
afformLocationType
branch
from
461bcb7
to
fa8dc3f
Compare
|
@seamuslee001 was that a MOP endorsement? |
|
Tested works well merging |
colemanw
added a commit
to colemanw/civicrm-core
that referenced
this pull request
Mar 17, 2022
Fixes dev/core#3120 Regression caused by civicrm#21218 Also fixes undefined variable errors when editing a block.
colemanw
added a commit
to colemanw/civicrm-core
that referenced
this pull request
Mar 18, 2022
Fixes dev/core#3120 Regression caused by civicrm#21218 Also fixes undefined variable errors when editing a block.
colemanw
added a commit
to colemanw/civicrm-core
that referenced
this pull request
Mar 18, 2022
Fixes dev/core#3120 Regression caused by civicrm#21218 Also fixes undefined variable errors when editing a block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Renames the ambiguously named "block" and "join" afform properties, and changes the naming convention to
"af{type}-title-munged".