dev/core#2777 - Fix js break on reminder form

[jitendrapurohit]

Overview

Fix js break on Reminder form.

Before

To replicate -

• Add an SMS provider on https://dmaster.demo.civicrm.org/civicrm/admin/sms/provider?reset=1 by installing twilio.

• Open Reminder form in AJAX popup.

• The form looks borked (title & CKEditor missing).

Console error -

which seems to be related to this change - #20220

After

Technical Details

Replace smarty crmScript with loadScript function.

Comments

Gitlab - https://lab.civicrm.org/dev/core/-/issues/2777

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Tested - looks good.
When I tested the original I probably didn't test popups.
Affects 5.40+

[eileenmcnaughton]

@jitendrapurohit do you want to do a 5.40 version of this PR? I don't guarantee there will be another 5.40 release but if there is this will be in it that way

[jitendrapurohit]

yes thanks @eileenmcnaughton. Have submitted at #21205