Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#2721 [REF] Further divide savedSearchParam loading into the sql functions #20954

Merged
merged 2 commits into from
Jul 27, 2021
Merged

dev/core#2721 [REF] Further divide savedSearchParam loading into the sql functions #20954

merged 2 commits into from
Jul 27, 2021

Commits on Jul 26, 2021

  1. [REF] start unravelling the way we retrieve the saved search 

    We have 3 types of saved searches
- search kit
- legacy core searches
- legacy custom searches

The only information these 3 need to load is the savedSearch details and
the group ID (to add in the add & exclude). The wrangling of the params should
happen in the getSql functions - which we can think about being in a listener once
they have standard inputs & outputs. However, to get to that point
we want to standardise those inputs & outputs. This removes
only point of randomness - ie savedSearch has a consistent value & the wrangling
of what is in it is pushed closer to the relevant functions
    @eileenmcnaughton
    eileenmcnaughton committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    d96f798 View commit details
    Browse the repository at this point in the history

  2. [REF] Further divide savedSearchParam loading into the sql functions

    @eileenmcnaughton
    eileenmcnaughton committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    c3f7cb2 View commit details
    Browse the repository at this point in the history