CRM_Case_Form_Activity - Fix PHP warning when opening case

[totten]

No description provided.

[dlobo]

Seems like this function and the class it extends break the signature of the original function in CRM/Core/Form.php

we might want to fix the signature in the Activity_Form_Activity class

lobo

[totten]

Yes, the blame is really with CRM_Activity_Form_Activity which makes the questionable design decision of adding an extra (optional) param to an overridden function. However, it is legal in PHP 5.3.14 and 5.4.4. The warning shows up on CRM_Case_Form_Activity (in PHP 5.4.4).

Just to restate what's going on, the class hierarchy here has a few levels, and the signatures of the overloaded functions look this in the current official code:

1. CRM_Core_Form::postProcess()
2. CRM_Activity_Form_Activity::postProcess($params = NULL)
3. CRM_Case_Form_Activity::postProcess() (==> warning <==)

The PR changes the hierarchy of overrides so that it's:

1. CRM_Core_Form::postProcess()
2. CRM_Activity_Form_Activity::postProcess($params = NULL)
3. CRM_Case_Form_Activity::postProcess($params = NULL)

This fixes the warning for me in PHP 5.4.4. (If you still get a warning in PHP 5.5, then I guess the rules have changed.) It sounds like the ideal patch would be to have:

1. CRM_Core_Form::postProcess()
2. CRM_Activity_Form_Activity::postProcess()
3. CRM_Case_Form_Activity::postProcess()

However, I can't really figure out when CRM_Activity_Form_Activity::postProcess is called with $params (ie can't find anything with grep), so I don't know how we would test the change. Maybe we could merge the current PR into 4.4 and then do the better change for 4.5?