[REF] Move pcpNotifyOwner to ContributionSoft #20522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Jun 7, 2021
| * @throws \API_Exception | ||
| * @throws \CRM_Core_Exception | ||
| */ | ||
| public static function pcpNotifyOwner(int $contributionID, array $contributionSoft): void { |
There was a problem hiding this comment.
function moved & param switched from contribution to contribution id (I could break this into 2 prs?)
This is cleanup towards civicrm#19096 in that it gets the function out of the form layer and also makes it so it does not require a BAO. This does add one extra db lookup in some cases but I think it's pretty low volume and will mean this is not required https://github.com/civicrm/civicrm-core/pull/19096/files#diff-4c9d0b1abe07057a4eea2b47bc627eecb95face8ed8d86c1c005312a52cca811R4271-R4273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Move pcpNotifyOwner to ContributionSoft
This is cleanup towards #19096 in that
it gets the function out of the form layer and also makes it so it does
not require a BAO.
Before
contribution BAO required as a param
After
contributionID required as a param
This does add one extra db lookup in some cases but I think
it's pretty low volume and will mean this is not required
https://github.com/civicrm/civicrm-core/pull/19096/files#diff-4c9d0b1abe07057a4eea2b47bc627eecb95face8ed8d86c1c005312a52cca811R4271-R4273
Technical Details
A git universe check did not find any other calls to this function
Comments
test cover in
testSubmitWithPCP()