Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make APIv4 Subscribers Public to fix D9 install #20254

Merged
merged 1 commit into from
May 10, 2021

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented May 8, 2021

Overview

This fixes a failure on the D9 demo install

                                                                                                                                                                                                                                                         
  [CiviCRM_API3_Exception]                                                                                                                                                                                                                               
  The "Civi_Api4_Event_Subscriber_PermissionCheckSubscriber" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.  
                                                                                                                                                                                                                                                         

Exception trace:
 () at /srv/buildkit/build/d9-master/vendor/civicrm/civicrm-core/api/api.php:134
 civicrm_api3() at /srv/buildkit/build/d9-master/vendor/civicrm/civicrm-core/CRM/Core/BAO/Setting.php:253
 CRM_Core_BAO_Setting::validateSettingsInput() at /srv/buildkit/build/d9-master/vendor/civicrm/civicrm-core/Civi/Core/SettingsBag.php:373
 Civi\Core\SettingsBag->setDb() at /srv/buildkit/build/d9-master/vendor/civicrm/civicrm-core/Civi/Core/SettingsBag.php:263

Before

This seems to be a slight regression from a9d469f and D9 demo build fails at this point

After

D9 Demo build installs CiviCRM correctly

ping @colemanw @totten @eileenmcnaughton

@civibot
Copy link

civibot bot commented May 8, 2021

(Standard links)

@civibot civibot bot added the master label May 8, 2021
@seamuslee001 seamuslee001 changed the base branch from master to 5.38 May 8, 2021 23:12
@civibot civibot bot added 5.38 and removed master labels May 8, 2021
@demeritcowboy
Copy link
Contributor

I see this with a "regular" install of drupal 9 + civi (not just demo build) and the patch fixes it. But will let others confirm since I'm not fully up on the original issue.

@colemanw
Copy link
Member

Fix seems simple & low-risk. Let's merge & see if that resolves things for the RC.

@colemanw colemanw merged commit ab70282 into civicrm:5.38 May 10, 2021
@eileenmcnaughton eileenmcnaughton deleted the fix_d9_install branch May 10, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants