Separates the default language for contacts from the site language

[VangelisP]

Overview

This is a PR related to the issue 2584

Before

Default language for contacts had 3 options:

• Use default site language
• Leave undefined
• Use language in use at the time

After

Default language for contacts renders the 3 options above plus all the available languages.

Technical Details

This PR adds the new languages to the selector and then on the CommunicationPreferences.php field examines what is the value of the configuration.

This works properly via the APIv3 as well.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mlutfy can you check this one?

[mlutfy]

Makes sense. Only minor review items on the code comments.

[VangelisP]

Thanks @mlutfy , I'll sort this out tomorrow!

[VangelisP]

If you think that the fixes are good to go, I can squash the 2 commits and force-push it.

[mlutfy]

Thank you @VangelisP, looks good to me!

I will leave open a few days to see if @bjendres has any feedback.

[bjendres]

Thank you @VangelisP, looks good to me!
I will leave open a few days to see if @bjendres has any feedback.

Looks like a thorough job to me, I don't have anything to add at this point :-)

[VangelisP]

Recapping what we got so far:

1. The admin interface will be rendering the previous 3 options plus (addition) all the available languages
2. We stick with the $availableLanguages = array_merge($availableOptions, CRM_Admin_Form_Setting_Localization::getDefaultLocaleOptions()); way to render the list
3. We prepopulate the field with the stored options only if the contact is new by adding a new conditional check on CRM-7119 for both edit and inline edit modes.

If we are happy, let me know and I can squash the commits into 1.

[eileenmcnaughton]

This looks correct to me know (squishing aside)

[eileenmcnaughton]

Actually I think this can be simplified further - I don't think we need to fall back to

 else {
          $config = CRM_Core_Config::singleton();
          $defaults['preferred_language'] = $config->lcMessages;
        }

because that would already have been returned from getContactDefaultLanguage if appropriate

[VangelisP]

You are right, this is being returned from getContactDefaultLanguage(), adjusting my code accordingly.

Thanks !

[eileenmcnaughton]

Yay