Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth-client - Add test for existing Auth Code flow behavior #20162

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

highfalutin
Copy link
Contributor

Preparation for work on the OAuth client extension to support OAuth tokens linked to particular contacts, as discussed with @totten at https://lab.civicrm.org/dev/core/-/issues/2181#note_58421

Before I make any PRs that change the inner workings of the auth code flow, this adds a test that asserts the existing behavior as a baseline.

@civibot
Copy link

civibot bot commented Apr 27, 2021

(Standard links)

@civibot civibot bot added the master label Apr 27, 2021
@eileenmcnaughton
Copy link
Contributor

Looks like jenkins doesn't love this as much as I do https://test.civicrm.org/job/CiviCRM-Core-PR/40573/checkstyleResult/new/

@highfalutin
Copy link
Contributor Author

oh Jenkins! PHPStorm is formatting my code to PSR-12 standards. Do you happen to know how I can tell it to use the style that Jenkins likes?

@highfalutin
Copy link
Contributor Author

highfalutin commented Apr 27, 2021

I think I wasn't understanding https://docs.civicrm.org/dev/en/latest/tools/phpstorm/#code-style-setup. I'll reformat.

@seamuslee001
Copy link
Contributor

this looks fine to me @totten ?

@totten totten changed the title Add test for existing Auth Code flow behavior oauth-client - Add test for existing Auth Code flow behavior Apr 28, 2021
@totten
Copy link
Member

totten commented Apr 28, 2021

Ooh, yes, please. More test coverage. :)

This is a test-only enhancement, so there's no r-run/r-user/etc. Looks pretty good and passes tests. Merging.

@totten totten merged commit e7524a9 into civicrm:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants