Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2509 - Remove unnecessary variable to make it easier to extract function that creates action links #20106

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

My end goal is to pull out the bit that makes the action links to make it reusable. Removing this unnecessary variable makes one less variable to pass around.

Before

Same

After

Same

Technical Details

Variable isn't used elsewhere in the function and value just passed to another function.

Comments

@civibot
Copy link

civibot bot commented Apr 20, 2021

(Standard links)

@civibot civibot bot added the master label Apr 20, 2021
@eileenmcnaughton eileenmcnaughton merged commit a8ec86f into civicrm:master Apr 21, 2021
@demeritcowboy demeritcowboy deleted the simplify-actionlink branch April 21, 2021 13:19
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants