Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Move function from static class to OO class #19955

Merged
merged 1 commit into from
Mar 31, 2021
Merged

[REF] Move function from static class to OO class #19955

merged 1 commit into from
Mar 31, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 31, 2021 •
edited by colemanw
Loading

Overview

[REF] Move function from static class to OO class

Before

self::mergeLocations($mergeHandler);

After

$mergeHandler->mergeLocations()

Technical Details

Very minimal move - clean up out of scope

Part of using the mergeHandler to (slowly) make code more readable.

Comments

@eileenmcnaughton
[REF] Move function from static class to OO class
a5e9dbe 
Part of using the mergeHandler to (slowly) make code more readable.

changes from

self::mergeLocations();

to mergeHandler->mergeLocations()
@civibot
Copy link

civibot bot commented Mar 31, 2021

(Standard links)

@civibot civibot bot added the master label Mar 31, 2021
@colemanw colemanw merged commit da4aa95 into civicrm:master Mar 31, 2021
@colemanw colemanw deleted the merge_locations branch March 31, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw