[REF] Extract portion of GroupContact load that builds the temporary table #19945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…table This is mostly a straight extraction. I chose to pass groupIDs in as an array as I think that creates greater flexibility and I chose to pass CRM_Utils_SQL_TempTable in rather than load it in the function because I have some ideas I'm working through about how that might also provide more flexibilty Those things can be changed later if we want as it IS a protected function
eileenmcnaughton
force-pushed
the
group_filter
branch
from
3e2cdf8 to
43a9636
Compare
|
Extraction makes sense & test coverage is very good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Extract portion of GroupContact load that builds the temporary table
Before
Yawn really long
After
Pithy (er)
Technical Details
This is mostly a straight extraction. I chose to pass groupIDs in as an array
as I think that creates greater flexibility and I chose to pass CRM_Utils_SQL_TempTable
in rather than load it in the function because I have some ideas I'm working through
about how that might also provide more flexibilty
Those things can be changed later if we want as it IS a protected function
Roughly a gazillion tests run through this function
Comments
@seamuslee001 @colemanw I realised the api part of how to do a group filter is pretty tricky but I figured I could help by cleaning up the code it might call - I have some interesting ideas brewing but I'm gonna try to write them elsewhere so they don't snarl up what is a fairly straight forward extraction