Code cleanup in bootstrap.php #19834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -84,7 +84,8 @@ | |||
| "ext-intl": "*", | |||
| "pear/mail_mime": "~1.10", | |||
| "pear/db": "1.10", | |||
| "civicrm/composer-compile-lib": "~0.3 || ~1.0" | |||
| "civicrm/composer-compile-lib": "~0.3 || ~1.0", | |||
| "ext-json": "*" | |||
There was a problem hiding this comment.
@eileenmcnaughton was this intentional?
There was a problem hiding this comment.
@seamuslee001 yep - per pr template - it communicates to the IDE that it is present. No impact on anything else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup - most but not all of these are in this PR (I left off a couple that were a bit harder to grok)
totten/civix#215
Before
minor coding infractions
After
Almost clean
Technical Details
Note the declaraition of php-json in composer helps the IDE but has no other impact (well maybe it would if someone really didn't have it)
Comments