Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Minor extraction to help cleanup permission code #19803

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[REF] Minor extraction to help cleanup permission code #19803

merged 1 commit into from
Mar 15, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 14, 2021 •
edited
Loading

Overview

[REF] Minor extraction to help cleanup permission code

Before

Code not extracted

After

tada

Technical Details

Just trying to improve the readability of the super_duper pr which will likely get a few eyes on

Comments

@civibot
Copy link

civibot bot commented Mar 14, 2021

(Standard links)

@civibot civibot bot added the master label Mar 14, 2021
@eileenmcnaughton eileenmcnaughton mentioned this pull request Mar 14, 2021
Merged
@colemanw
Copy link
Member

retest this please

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor Author

hmm still failing on stuff that seems unrelated to the change

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit 835c9b6 into civicrm:master Mar 15, 2021
@eileenmcnaughton eileenmcnaughton deleted the little_bit_super branch March 15, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @colemanw @seamuslee001