[Ref] Remove copy and paste overkill

[eileenmcnaughton]

Overview

Remove some code that is on this form due to previously being present in code shared with the front end form but doesn't make sense here

Before

• A transaction is used - but not in a way that reflects the form
• A form variable is used - but only in one of many flows through the form

After

poof

Technical Details

This is a previously shared function that was copied and pasted back. However in the
context of this form they don't make sense because

1. It doesn't make sense to try to maintain the integrity (via the transaction)
   of the contribution & recurring contribution over & above the other
   items on the form - without the memberships they don't actually have integrity
   and this might have made a little more sense front end in terms
   of ensuring they were committed if a payment is made but
   we can expect a back office user to observe an error

2. setting the contribution id on the form here doesn't make sense as
   this line is only hit for credit-card recurring contributions and
   either we are doing it elsewhere anyway or we should do it nowhere - there
   is no logic for 'only do this in this one obscure flow' that makes
   sense back office. Front office this was likely added for an otherwise missed
   scenario

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 are you OK to merge this - I think I've made the case why the lines (originally copied from the front end form) don't make sense on the backend form given that they ONLY apply to a narrow range of submissions on this form

[seamuslee001]

@eileenmcnaughton can you rebase now

[colemanw]

test this please