Fix apiv4 test sloppiness #19754
Merged
Fix apiv4 test sloppiness #19754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why would we exclude e-notices from causing test fails - I suspect this canary-killer got added a long time back & no-one noticed
|
(Standard links)
|
|
👍 |
|
Ooh, those birds have been down that mineshaft a long time. It's awful quiet down there... I wonder how they're doing. |
|
No canaries were hurt in the running of this test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a hack that stops apiv4 unit tests finding all code problems (I hate to think)
Before
All canaries are shot before entering the mine
After
Personalised health care tracking available to canaries
Technical Details
Why would we exclude e-notices from causing test fails - I suspect this
canary-killer got added a long time back & no-one noticed
Comments