Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SocialNetwork.tpl Twitter Intent URL #19724

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Conversation

alexymik
Copy link
Contributor

@alexymik alexymik commented Mar 4, 2021

Overview

Update Twitter intent URL in the Social Network "Help spread the word" template.

Technical Details

URL was updated some time ago from https://twitter.com/share to https://twitter.com/intent/tweet

https://developer.twitter.com/en/docs/twitter-for-websites/tweet-button/guides/web-intent

@civibot
Copy link

civibot bot commented Mar 4, 2021

(Standard links)

@civibot civibot bot added the master label Mar 4, 2021
@totten
Copy link
Member

totten commented Mar 5, 2021

Change looks pretty safe.

A quick test shows that twitter.com/share redirects to twitter.com/intent/tweet, so it's demonstrably the same functionality -- just getting through the newer URL and with fewer redirects. ✅

Cheers @alexymik !

@totten totten merged commit 16d5ffe into civicrm:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants