dev/core#2423 Fix quasi-regression around serialized custom fields

[eileenmcnaughton]

Overview

dev/core#2423 Fix quasi-regression around serialized custom fields

https://lab.civicrm.org/dev/core/-/issues/2423

Before

2 issues - first create a custom field of type 'Integer' with html 'drop down select' and choose 'mutliple.
Issue 1 - the table with be created with the fields having the mysql type of Integer
Issue 2 - the field validation will expect the field to be an integer and reject concatenated values

After

Much better

Technical Details

Comments

@colemanw

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton these 2 failures look like they relate

CRM_Core_BAO_CustomValueTableSetGetTest.testSetGetValuesDate
CRM_Core_BAO_CustomValueTableSetGetTest.testSetGetValuesYesNoRadio

[eileenmcnaughton]

@seamuslee001 I think I got it - hard to imagine there isn't a better fix.....

[colemanw]

I reviewed the code and this indeed looks like the right fix, as it correctly applies the serialized field type (varchar) regardless of FK.
Tests are passing (except for a weird leap-year bug in the test suite).