Enable & do single field metadata conversion for defaultContactCountry #19697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds on civicrm#19629 Our intention is that we should be building functionality into this form that is actually used in core. It's a bit tricky to swap out all fields at once but this makes them individually swap-outable. Only defaultContactCountry is swapped out. I looked a little at the help_text issue - the text actually does work if you add it since it's already in the hlp file but I decided this broke consistency less (using description) as other fields on the form do that and look similar. Also, when the text is really just a bit of text (not a long help text) it makes sense. (Otherwise I'd need to trawl through resolving the bigger issue and I didn't want to bring that into scope)
|
(Standard links)
|
|
test this please |
|
Just noting that when further cleanup is done, we should get rid of that godawful "advmultiselect" widget for "Pinned Countries".
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Enable & do single field metadata conversion for defaultContactCountry
Before
tpl for defaultContactCountry does not use metadata for the field
After
Metadata used, ability to convert field-by-field to break it up
Technical Details
This builds on #19629
Our intention is that we should be building functionality into this
form that is actually used in core. It's a bit tricky to swap out
all fields at once but this makes them individually swap-outable.
Only defaultContactCountry is swapped out. I looked a little at the
help_text issue - the text actually does work if you
add it since it's already in the hlp file but I decided this
broke consistency less (using description) as other fields
on the form do that and look similar. Also, when the text is
really just a bit of text (not a long help text) it makes sense.
(Otherwise I'd need to trawl through resolving the bigger issue
and I didn't want to bring that into scope)
This shows it with the description AND the help icon - note the help icon is not aligned as the overall
form is not yet standardised
With just the description
And other fields on the same form
Comments