dev/financial#166 Fix for inconsistency around currency symbol

[eileenmcnaughton]

Overview

Potential fix for inconsistencies around money handling in code that should not display a currency symbol

Before

On some (most?) installs

CRM_Utils_Money::formatLocaleNumericRounded(20.453, 2)

returns 20.45 or 20,45 depending on the locale

But on others appears to return $20.45

After

Hopefully it's more consistent (pending response from @MegaphoneJon & @larssandergreen )

Technical Details

From https://lab.civicrm.org/dev/financial/-/issues/166 we learn that the existing code
(tested via testFormatLocaleNumericRoundedByCurrency) is not consistent across
all platforms. I think this may be

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

I can confirm that this resolves the issue in my environment.

I'm not sure what all is relevant here - but I'm using PHP 7.3 on Ubuntu with the Sury Ondrej repos with php-intl installed (via the repo).

[eileenmcnaughton]

@seamuslee001 @mattwire @monishdeb - looks promising

Thanks @MegaphoneJon - I didn't have the problem & it still works. You did & this fixes so it seems at least better!

[demeritcowboy]

I couldn't replicate the original issue with the symbol, but noting that in some locales $formatter->setSymbol(\NumberFormatter::CURRENCY_SYMBOL, ''); wouldn't have been completely correct anyway because you get trailing spaces, e.g. in some locales the usual way of writing might be 12,34 €, so you end up with a trailing space.

[colemanw]

@eileenmcnaughton can you pls rebase

[eileenmcnaughton]

@colemanw done

[seamuslee001]

Test fails un related