Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - cleanup display configuration and add "rewrite" feature #19662

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

colemanw
Copy link
Member

Overview

Adds the ability to rewrite fields in search displays, while streamlining the display administration screen.

Before

image

After

image

Comments

De-cluttering inspired by conversation with David Tarrant

@civibot
Copy link

civibot bot commented Feb 24, 2021

(Standard links)

@civibot civibot bot added the master label Feb 24, 2021
@dptarrant
Copy link

I like the look - much cleaner :) Using test site I do not see the Display on new line option.
image

@colemanw
Copy link
Member Author

Using test site I do not see the Display on new line option.

My screenshot was from a List display and yours is from a Table. That's the difference.

@seamuslee001
Copy link
Contributor

Jenkins retest this please

@colemanw
Copy link
Member Author

retest this please

@dptarrant
Copy link

Not sure what to test. Yes, the issue was as Coleman pointed out. Is that what is meant by retest?

@colemanw
Copy link
Member Author

@dptarrant no those are commands to civibot to re-run the automated tests.

@seamuslee001
Copy link
Contributor

Merging based on @dptarrant comments and that this looks good to me r-code wise

@seamuslee001 seamuslee001 merged commit 931f2ba into civicrm:master Feb 25, 2021
@seamuslee001 seamuslee001 deleted the searchDisplayRewrite branch February 25, 2021 20:22
@eileenmcnaughton
Copy link
Contributor

@dptarrant thanks for testing / giving feedback. I agree this looks cleaner!

@JoeMurray
Copy link
Contributor

Significant improvement. Thanks @dptarrant and @colemanw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants