Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move code that relates to receipts when paying by credit card out of the shared function #19658

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Move code that relates to receipts when paying by credit card out of the shared function

Before

Code only used by back office membership form is in a function shared with the Batch Entry form

After

Code is in a function only used by back office membership form

Technical Details

The emailReceipt function is shared between the Batch Entry form and the backoffice
credit card form, while the emailMembershipReceipt is only used in this function.

I aim to copy the function onto the Batch Entry form & split them up but
am first moving this out of the shared code as it only
relates to credit card payments, which are not reachable from the Batch Entry form

Comments

…ut of the shared function

The emailReceipt function is shared between the Batch Entry form and the backoffice
credit card form, while the emailMembershipReceipt is only used in this function.

I aim to copy the function onto the Batch Entry form & split them up but
am first moving this out of the shared code as it only
relates to credit card payments, which are not reachable from the Batch Entry form
@civibot
Copy link

civibot bot commented Feb 23, 2021

(Standard links)

@civibot civibot bot added the master label Feb 23, 2021
@mattwire mattwire merged commit 3a23df8 into civicrm:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants