[Regression] campaign name no longer accepted

[eileenmcnaughton]

Overview

In master we removed the pseudoconstants on campaign_id fields with the intent they would rely on the FKs.

This adds a shim for APIv3 to maintain legacy support for getoptions on fields named campaign_id.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

First test fail looks related and expected

[colemanw]

Right. APIv3 will no longer accept campaign name in place of the id.
The fix is to update your WMF code to pass campaign id instead of campaign name to the api.

[mattwire]

I can see this causing unexpected breakage elsewhere too. At the very least I think this breaking change to API3 needs to be flagged in the release notes and a pre-upgrade message.

[eileenmcnaughton]

@colemanw I think we have to find a way to handle this in the apiv3 code - even if it is hacky

[eileenmcnaughton]

@colemanw I am guessing the test fails might be due to unique_name vs name_name

CRM_Core_BAO_ActionScheduleTest::testInheritedMembershipPermissions
Failure in api call for relationship create: '30' is not a valid option for field campaign_id
#0 /home/jenkins/bknix-dfl/build/core-19633-773vc/web/sites/all/modules/civicrm/CRM/Contact/BAO/Relationship.php(2383): civicrm_api3('Membership', 'create', Array)

[colemanw]

@eileenmcnaughton the test fail was because I forgot my v3 syntax and typed 'limit' => 0 instead of 'options' => ['limit' => 0] so the list was truncated. Yet another victim of the v3 "limit 25" problem, and a good thing tests caught it.

[eileenmcnaughton]

@colemanw nice