dev/core#2365 - Delayed drawing of contribution charts seems unnecessary

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2365

Maybe there's a reason, in which case I'm happy to close this, but it seems unnecessary.

Steps to reproduce.

1. Visit contribution dashboard.

Before

• Purposely delayed 1.5 seconds before chart appears.
• I'll often start to click on something in the table and then the row moves and I end up clicking on something else.

After

It just draws.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

Ping @artfulrobot who touched this last I think

[eileenmcnaughton]

I agree that @artfulrobot is a good person to get input from - also adding to dev-digest in case anyone wants to weigh in - I would probably merge in by the end of next week absent any input.

I find the removed comment particularly terrifying....

Delay rendering so that animation looks good.

It feels like the equivalent of saying

Ensure comic sans is installed so the presentation looks professional

[demeritcowboy]

[artfulrobot]

@eileenmcnaughton I've commented over on https://lab.civicrm.org/dev/core/-/issues/2365#note_53812

but sure, if you have animated charts then -mostly- the animation is there to make 'em look good. If they don't look good because they're all jerky then it the animation looks worse than not having any. Hence the delay.

If we can't get a happy compromise, I wonder if there's a way to tell the charting lib not to animate it at all, and go for snappy and informative rather than look-at-us-we're-almost-modern.

(If it's not clear: I definitely agree with scrapping the delay if it's causing usability issues as reported. Just wonder if it we can also turn it off?)

[demeritcowboy]

I should clarify. There's the animation of the bar zooming from 0 to N, which is still there and looks nice, and the delay of insertion of the chart itself, which is what I'm suggesting to remove. Here's a screencap, just the timing is better to see if you just r-run it since the framerate here isn't the same as reality's framerate (or more accurately, the frame rate of the simulation our universe is running in).

BEFORE

AFTER

[eileenmcnaughton]

I'm merging this as there doesn't seem to be any contention about removing it