[REF] Remove unused pcp & soft credit handling from previously shared code #19525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code the ProcessContribution function has been split out from a shared function used by front end forms and I'm pretty sure it was only relevant for those other forms. The only code that calls this function is when a payment processor is used in recurring mode to pay for a membership. I tested doing this and selected 'record payment from a different contact' without these lines & it created the soft credit (using the code elsewhere in the function that would be used if it were not recurring or not credit card payment)
|
(Standard links)
|
|
@eileenmcnaughton Looks good, merging this. |
|
Thanks @yashodha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Remove unused pcp & soft credit handling from previously shared code
Before
Lines exist, do nothing
After
poof
Technical Details
the ProcessContribution function has been split out from a shared function used by front end forms
and I'm pretty sure it was only relevant for those other forms. The only code that calls this function
is when a payment processor is used in recurring mode to pay for a membership.
I tested doing this and selected 'record payment from a different contact' without these
lines & it created the soft credit (using the code elsewhere in the function that
would be used if it were not recurring or not credit card payment)
Comments