Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove another use of loadRelatedObjects() function #19505

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Feb 2, 2021

Overview

We don't need to call loadRelatedObjects() until we get to composeMessageArray() function. I've changed $loadAll to TRUE because that's how the parent function was calling it so this ensures the same data is available.

Before

More calls to deprecated functions.

After

Less calls to deprecated functions.

Technical Details

Comments

@eileenmcnaughton This probably makes most sense to you :-)

@civibot
Copy link

civibot bot commented Feb 2, 2021

(Standard links)

@civibot civibot bot added the master label Feb 2, 2021
@mattwire mattwire changed the title Remotememrelated Remove loadRelatedMembershipObjects() function Feb 2, 2021
@mattwire mattwire changed the title Remove loadRelatedMembershipObjects() function Remove another use of loadRelatedObjects() function Feb 2, 2021
@eileenmcnaughton
Copy link
Contributor

@mattwire yep - I checked & it seems fine. composeMessageArray is on called from this one place (& I don't think it's params need to be pass-by-ref)

@seamuslee001
Copy link
Contributor

Merging as per @eileenmcnaughton 's review

@seamuslee001 seamuslee001 merged commit cd49844 into civicrm:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants