Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Kit: Misc bug fixes #19489

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Feb 1, 2021

Overview

Fixes bugs documented in dev/core#2349 and dev/core#2347

@civibot
Copy link

civibot bot commented Feb 1, 2021

(Standard links)

@civibot civibot bot added the master label Feb 1, 2021
@eileenmcnaughton
Copy link
Contributor

Yep this fixes - what makes financial_tyoe_id present by defaut on new contribution search @colemanw ?

@eileenmcnaughton eileenmcnaughton merged commit 68d1ec5 into civicrm:master Feb 1, 2021
@eileenmcnaughton eileenmcnaughton deleted the searchKitBugs branch February 1, 2021 20:16
@colemanw
Copy link
Member Author

colemanw commented Feb 1, 2021

@eileenmcnaughton the same thing that makse "Display Name" appear on contact searches by default - a hard-coded list in SearchKit of default columns to show.
In the next release cycle I want to improve that using metadata.

@eileenmcnaughton
Copy link
Contributor

@colemanw ok cool - I'm sure you'll get feedback on that once people get into testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants