dev/financial#162 Simplify isPdf code

[eileenmcnaughton]

Overview

This makes the same simplification as https://github.com/civicrm/civicrm-core/pull/19165/files
in another part of the code. The correct setting name has the invoice_ prefix
(although I think our handling code was making the other work)

Before

Drawn out code

After

Agreed simplification -in addition in one place the use of isset rather than !empty was resolving to true even when it should have been false - which is how I wound up in this code

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Jenkins retest this please. (Warning: PDO::query(): MySQL server has gone away)

[eileenmcnaughton]

Yeah - it's doing that a lot!

[demeritcowboy]

This is mostly a code review and am relying on the previous PR.

• General standards
  • [r-explain] Soft pass
    • It's touched on in the other PR but maybe one of the reasons this PR has sat here for a while is that it's not at all clear what civi does voodoo-wise with invoice settings. So when reading this PR it's helpful to know that there are two sets of settings that set/get the same things. There's contribution_invoice_settings which is an array, and then a mirror set of flattened settings where the names are sometimes (?!) prefixed with invoice_, and then also there's one called invoicing which in the original is a subarray, and in its mirror is just a boolean.
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] Quick PASS
    • I just did a very light run of the contribution page invoice.
• Developer standards
  • [r-tech] PASS
    • Am relying on whatever other discussions have happened and haven't tried to follow it.
  • [r-code] PASS
  • [r-maint] ?
  • [r-test] Pending Re-running since it's been a while.

Jenkins retest this please.

[eileenmcnaughton]

@colemanw OK to merge based on review ^^

[demeritcowboy]

jenkins retest this please (just been a while)

[seamuslee001]

merging as per review from @demeritcowboy

[eileenmcnaughton]

Thanks @demeritcowboy @seamuslee001