dev/core#2333 Fix issue when clicking on alpha links from 'amtg' search #19472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Thanks. It works for me. |
|
Merging as per review from @demeritcowboy |
| 'force' => 1, | ||
| 'qfKey' => $qfKey, | ||
| ]; | ||
| if ($query->_context === 'amtg') { |
There was a problem hiding this comment.
Oops this is throwing a notice on contribution and event page listings. PR: #19515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2333 Fix issue when clicking on alpha links from 'amtg' search
https://lab.civicrm.org/dev/core/-/issues/2333
Before
Add New Group via Manage Groups screen
Make it a mailing list
search for all contacts
click on letter M (or any letter)
Expected - see Contacts with last name M
Actual: Bounced back to group creation page
After
Fixed
Technical Details
Awful code but should be a fairly narrow fix as amtg context = add Members to Group I think
Comments
@kcristiano @demeritcowboy - note I'm targetting master as this doesn't seem very recent