[REF] Remove seemingly unreachable attempt to format activity_date_time

[eileenmcnaughton]

Overview

[REF] Remove seemingly unreachable attempt to format activity_date_time

Before

Check for $key === 'activity_date_time' within a check whether $key is in the format 'custom_4' would never be true

After

poof

Technical Details

This is within the if custom field section - it would never be true but formatting exists further down

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Interesting:

• It was above the custom if originally, and then was removed here: civicrm/civicrm-svn@89feb80
• Then it was put back here, but inside the if: 2272a06
• Then somebody took it out: 7cad3e5
• And then a month later somebody put it back: 8bc84e3

I tested and everything looks ok. The mentioned issue in there about importing a custom field of type country seems to work ok.

[eileenmcnaughton]

@demeritcowboy this stuff is all over the place - also check #19111 where I decided ripping out a bunch of code makes custom data imports work better....

[demeritcowboy]

I can look at 19111 but yeah that one would be good to have a couple people throw things at it.

This PR looks fine to me. I'm noticing now time components of dates don't import properly but that seems the same before and after.

[colemanw]

Merging because it "looks fine" to demerit