Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - delete unused, nonfunctional apis #19432

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

colemanw
Copy link
Member

Overview

Removes a couple unused APIs from the Afform extension. They don't do anything.

Before

Code present, does nothing.

After

Code gone. Still does nothing but with fewer lines of code :)

Comments

I can't remember what these were supposed to be for. Maybe @totten does.

@civibot
Copy link

civibot bot commented Jan 21, 2021

(Standard links)

@civibot civibot bot added the master label Jan 21, 2021
@totten
Copy link
Member

totten commented Jan 22, 2021

I can't remember what these were supposed to be for.

"Palette" ==> List of things that you can select and add to a canvas. These are basically small snippets of HTML that one drops into the canvas.

The earlier intent had been to model the palette in a way that gave API visibility (i.e. the data-model of the palette would be clearly defined/tracked/searchable in the conventional way). But, as it stands, I think this is organized privately via CRM_AfformAdmin_Utils::getGuiSettings() and client-side code.

At this point, to get the benefit of a conventionally-shaped API for palette content, one would have to approach it is a refactoring subproject that's more attuned to the de facto model. Not much point keeping the skeleton around.

r-tests are passing. Merging.

@totten totten merged commit 374b308 into civicrm:master Jan 22, 2021
@colemanw colemanw deleted the afformApiCleanup branch January 22, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants