Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2313 SearchKit - Default join conditions #19429

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

colemanw
Copy link
Member

Overview

Makes joins in Search Kit more intuitive by automatically adding commonly-used default conditions.

https://lab.civicrm.org/dev/core/-/issues/2313

Before

Adding join entity looks like this:
image

After

Adding activity join looks like this:
image

Technical Details

As with everything SearchKit, this uses a metadata-driven approach, introducing @ui_join_filters annotations for APIv4 entities.

Adds @ui_join_filters annotations to APIv4 entities which automatically shows that field when adding a join

https://lab.civicrm.org/dev/core/-/issues/2313
Switching a join was confusing and buggy. Best to disable that and only allow them to be deleted
@civibot
Copy link

civibot bot commented Jan 21, 2021

(Standard links)

@civibot civibot bot added the master label Jan 21, 2021
@eileenmcnaughton
Copy link
Contributor

Definitely an improvement - probably we also want the same experience from activities - but I'll kick the tyres some more on this next week

@eileenmcnaughton eileenmcnaughton merged commit c986f42 into civicrm:master Jan 22, 2021
@eileenmcnaughton eileenmcnaughton deleted the searchJoinDefaults branch January 22, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants